#25 cicd pipeline 구축 #33
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Caution Review failedThe pull request is closed. Walkthrough이번 변경 사항은 메뉴 및 스토어 이미지 관리 기능을 대폭 확장하고, AWS S3 연동 및 비동기 처리를 도입하였습니다. 신규 도메인(메뉴, 메뉴 이미지, 스토어 이미지)에 대한 엔티티, DTO, 서비스, 컨트롤러, 리포지토리가 추가되었으며, 관련 배포 자동화 및 빌드 설정도 함께 반영되었습니다. Changes
Sequence Diagram(s)sequenceDiagram
participant Client
participant MenuController
participant MenuService
participant MenuRepository
participant MenuImageRepository
participant S3Service
participant AmazonS3Client
Client->>MenuController: POST /menus/create (MenuCreateRequest)
MenuController->>MenuService: createMenu(request)
MenuService->>MenuRepository: save(Menu)
MenuRepository-->>MenuService: Menu
MenuService-->>MenuController: MenuCreateResponse
MenuController-->>Client: 201 Created
Client->>MenuImageController: POST /menus/{menuId}/images (file)
MenuImageController->>MenuImageService: save(menuId, file)
MenuImageService->>MenuRepository: findById(menuId)
MenuImageService->>S3Service: upload(type, menuId, file)
S3Service->>AmazonS3Client: putObject(...)
AmazonS3Client-->>S3Service: S3 Upload Result
S3Service-->>MenuImageService: S3UploadResult
MenuImageService->>MenuImageRepository: save(MenuImage)
MenuImageRepository-->>MenuImageService: MenuImage
MenuImageService-->>MenuImageController: MenuImageUploadResponse
MenuImageController-->>Client: 201 Created
sequenceDiagram
participant Client
participant StoreImageController
participant StoreImageService
participant StoreRepository
participant S3Service
participant AmazonS3Client
Client->>StoreImageController: POST /stores/{storeId}/images (files, types)
StoreImageController->>StoreImageService: saveAll(storeId, files, types)
StoreImageService->>StoreRepository: findById(storeId)
loop for each file
StoreImageService->>S3Service: upload(type, storeId, file)
S3Service->>AmazonS3Client: putObject(...)
AmazonS3Client-->>S3Service: S3 Upload Result
S3Service-->>StoreImageService: S3UploadResult
end
StoreImageService->>StoreImageRepository: save(StoreImage)
StoreImageRepository-->>StoreImageService: StoreImage
StoreImageService-->>StoreImageController: List<StoreImageUploadResponse>
StoreImageController-->>Client: 201 Created
Possibly related PRs
Suggested labels
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (38)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
작업 요약
Issue Link
문제점 및 어려움
해결 방안
Reference
Summary by CodeRabbit
신규 기능
개선 및 변경
CI/CD 및 배포
의존성 및 설정
보안
이 릴리즈를 통해 이미지 관리 및 파일 업로드, 메뉴 관리 등 다양한 기능이 새롭게 제공됩니다.